Must agree with Schmedlap about Lawrence. I would go further regarding Lansdale. Although I never met him, I do know people who did and found him impressive on a personal level. His book, In the Midst of Wars rings true to me regarding his experiences advising both Magsaysay and Diem. I say "rings true" from the perspective of one who has spent much of my career both as a soldier and a civilian in advising roles in Latin America. This is not to say that Lansdale was always successful at a strategic, operational, or tactical level. he had his failures as we all have. Success as an advisor, I would define, as being able to achieve a rapport with one's counterpart and mor often than not come to agreement on courses of action that advance both your causes.

Regarding your points 1 -3: I agree. I would only add that my experience with number 3 is that we all have our agendas and my goals were to advance those of my counterpart that advanced my own/my country's.

Cheers

JohnT